atg / chocolat-public

Public bug tracker for the private chocolat project
http://chocolatapp.com
182 stars 4 forks source link

Indentation guides not showing on empty lines (3.3.1) #1793

Open alexanderweiss opened 7 years ago

alexanderweiss commented 7 years ago

When enabling indentation guides, they will only show up on lines with actual tabs. So, when blank lines are trimmed, these lines don't show the indentation guides. The result is holes that make them quite a bit less helpful. I've added this quick graphical representation:

Expected:

class SomeClass {

    constructor() {
    |
    |   super()
    |
    |   return this
    |
    }

}

Actual:

class SomeClass {

    constructor() {

    |   hello()

    |   return this

    }

}
ludwigschubert commented 7 years ago

I always thought that was intentional to show there was no whitespace on these lines. But reading your issue I realize guides would be more helpful if they worked like you suggest.

atg commented 7 years ago

Yes it wasn't intentional, just laziness on my part. Although secretly I quite like the way it works currently. It makes it easy to see which lines have what amount of whitespace. I guess if I fixed this it would have to be a preference.