search

athackst / dockerfiles

Dockerfiles I use for development
https://althack.dev/dockerfiles
Apache License 2.0
192 stars 41 forks source link

Add jazzy to dockerfiles #461

Closed athackst closed 2 months ago

athackst commented 2 months ago

It doesn't look like there's a cuda image for 24.04

Ubuntu 24.04 now comes with an "ubuntu" user on 1000:1000 as the nonroot user. This PR deletes that user in favor of the "ros" user to match previous images.

Closes #456

jncfa commented 2 months ago

One thing, the ubuntu 24.04* docker image now has a default user ubuntu with UID/GID 1000, which is why the CI is failing https://bugs.launchpad.net/cloud-images/+bug/2005129

I opted to delete the user on the image with userdel -r ubuntu, and everything else should work the same after

athackst commented 2 months ago

Thanks!

I'm considering removing the part that adds a non-root user to the image - but it feels like too big of a change for this.

jncfa commented 2 months ago

Wouldn't that cause issues with users of your vscode_workspace_ros2? Unless I'm missing something, I see some references to the "ros" user or its home folder that would cause issues 😕

athackst commented 2 months ago

There's not that many. Maybe 3 total? I'm punting on that for now anyway. This change should build the jammy image with the ros user instead.

jncfa commented 2 months ago

There's not that many. Maybe 3 total? I'm punting on that for now anyway. This change should build the jammy image with the ros user instead.

Sounds good, just thought I should bring up that up

Thank you for all your hard work on these projects! 😄