search

athanclark / purescript-websocket-moderate

A different websocket binding for purescript
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Update argonaut compatibility #2

Closed thomashoneyman closed 4 years ago

thomashoneyman commented 4 years ago

The most recent major release of the Argonaut library introduces typed errors. This PR updates this library for compatibility via Bower or Spago.

I added overrides so that this can be built via Spago locally. Those overrides can be removed once the next package set is released, as tracked by this issue: https://github.com/purescript/package-sets/issues/642

If everything looks good, would you mind making a new release with the updated code so it's compatible with the upcoming package set? That'll ensure this package stays in the set. Once the next package set is released then it can be updated in this project's spago.dhall file and the overrides can be removed (they won't be necessary anymore).

Sorry for the hassle! Thanks!

thomashoneyman commented 4 years ago

The CI failure is due to psc-package -- I could work to update this as well, but given that Spago has superceded psc-package it might be worth removing instead.

athanclark commented 4 years ago

Awesome! No worries, thank you for adding this!