Closed adhirajpawar closed 2 weeks ago
Great work on this issue! š Iām really happy with the changes you made to the landing page. It looks fantastic and is much more user-friendly now. Thank you for your contributions and for helping to enhance our project! If you have any more ideas or want to tackle another issue, feel free to jump in! #1
Okay
On Fri, Oct 4, 2024, 1:26 PM Adhiraj Pawar @.***> wrote:
Overview
This PR fixes the layout issues on the landing page when viewed on small screens (mobile devices). Issue Reference
Fixes #42 Changes Made
- Adjusted the CSS for the navigation bar to prevent overflow on small screens.
- Updated the media queries to improve responsiveness for devices with screen widths under 600px.
- Fixed alignment issues with the hero image and text in the header.
Hacktoberfest
This PR is submitted as part of Hacktoberfest 2024. I hope this contribution helps improve the project!
You can view, comment on, or merge this pull request online at:
https://github.com/atharvbarge04/Landing-page/pull/2 Commit Summary
- f9a060b https://github.com/atharvbarge04/Landing-page/pull/2/commits/f9a060b3e7d692c61e321fc55438132d46755171 fix navbar layout issue on small screens
File Changes
(36 files https://github.com/atharvbarge04/Landing-page/pull/2/files)
- A assets/css/styles.css https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-447f1d1a72b4c07f78281064a4d160950b50b5af2552302b3aec4e28181534ab (769)
- A assets/img/case.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-10ba879477e5aa44016405d17a3de942ba58b4728ea6289dd5651982d5ddde8e (0)
- A assets/img/discount.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-338b4d48cf930b59688fa1607a8ab2b51acc759dde19becaf0d1c8e4acbafa96 (0)
- A assets/img/favicon.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-519782ff81f1181664394e18bb5cc43e6a3d90b31c0edb00b6e8d068428e6fc5 (0)
- A assets/img/home.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-96b22e63576c5e67aa919f935e9a39ae8a6c3375539ca781de1e303bed65d22c (0)
- A assets/img/logo.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-b6daf8fdbaca4369d5ba7fc6a15533889fd70f5622ce87653f03648eb575d9d0 (0)
- A assets/img/product1.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-29baf62406191230156bc374fd10dde11dab5274a4de38eaf198d57dea9ad87d (0)
- A assets/img/product2.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-8260066df5368ec2ab3bd53ea54020be3ff78200be11c4440322ef230d0e5e57 (0)
- A assets/img/product3.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-33e96ab8d19d78bb0e3d9d77ab453a062e6c7bbcc7b503c0133abd5518079504 (0)
- A assets/img/product4.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-30d4ed9960429721a9da4e68fd5a9bbbcd5fb92f2e770c69cc3734623727856a (0)
- A assets/img/product5.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-0d7107d5311e30c50f7621481c31a9053c791a63604606f5466e4d39d3f5130a (0)
- A assets/img/specs.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-fe25be569b67f796ff1e99ad9ef461e5635bfd8c4f4ad6082fcbb919f17437e5 (0)
- A assets/img/sponsor1.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-b20c44aefc07cf46a0d38fcc062fff59687d2d22b473b516772ba294f838c08a (0)
- A assets/img/sponsor2.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-639163fc25dd6ad8fcd007cb7f38318f5f7c77286842da950795fcd050961cda (0)
- A assets/img/sponsor3.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-494a6290482f9c76640f4e3085df4bfb8f05dad9cd8c1fc0f89f2fb85dd6d0b0 (0)
- A assets/img/sponsor4.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-bc2492ec39cb6d1efac0f3988a77460d753770d5f9536cfb4f414d58a53879df (0)
- A assets/js/main.js https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-a493911cce6d7ca19a7be9aeed7cd061d2f676a65e843a240d919a817e34e292 (84)
- A assets/scss/base/_base.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-24cbfda143810218dd920a4a4ae66541bca39d998601b69c497e4e19a7cb6a45 (41)
- A assets/scss/components/_buttons.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-57ab30b84aa726a68ac0fe0b7c5dc93182042c3acd74f3405b36d6c2efa400b4 (23)
- A assets/scss/components/_case.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-5ec0e56e6030c99ddcbb88e96b10a6fc8cdfece16a1b110b9b6baed5df2df538 (19)
- A assets/scss/components/_discount.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-8fdaaef2c809620b57f3bfc9284816e2f1b73c30df92f146e9d4815f0765d59f (22)
- A assets/scss/components/_footer.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-02b0a499394916d4d4f758cef4d685f292de1a28bd8a9824ba9671bb108684ff (73)
- A assets/scss/components/_header.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-03f282cbb5eceb9ba890d447026e8a9d075698521d71e113a66cd0f89c9d15a1 (88)
- A assets/scss/components/_home.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-91caa74e5ef8a84e2edb43ea03191543f52af54593171e2dbe5e7f862e2f9d90 (44)
- A assets/scss/components/_mediaqueries.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-692bd63378d58872acdbdc510cb2eb1aa5a09a5bf6eb25cd5ca9250bdf822719 (248)
- A assets/scss/components/_products.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-547efc256a56547077a10dcd4747c0e853d5647c1559c1542eac45c28b7ef8ac (44)
- A assets/scss/components/_scroll.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-3e2d15aad8c26f89517553bc2f3c1a5344e6c02a4bbc19388624945547d101bb (42)
- A assets/scss/components/_specs.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-81b0a94a9a2a0851e32ce25a0e3cdb4972b7e76f991e76e87f7170d6403c6b7e (34)
- A assets/scss/components/_sponsor.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-c8b5cabb87184234201ea5b432ce36aa36016997d80ea000b1a4b653e25e2f2b (12)
- A assets/scss/config/_variables.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-229a6a87d211ef3f8a4cdc833ebfeeb9a69358979f9d73939a89303535b50bde (62)
- A assets/scss/layout/_layout.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-3832c7a72af1d95a16d6786e44f794fc20ede7db757b1986cd1058e6d77dd892 (32)
- A assets/scss/styles.scss https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-cf0245b1e5d093818e605c066954bfe388978bb0c5de2007738324ea230dc86b (14)
- M index.html https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051 (377)
- A preview.png https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-d53de3d4e8e9ef98ef13ad2979a2e3ff7b939ac6ce4608bd431f0430fdf5e911 (0)
- D script.js https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-ed3ee7e0beea2498ff3b8ca85973d122fc6fa3d585d62b5807ec034d0cf076b3 (9)
- D style.css https://github.com/atharvbarge04/Landing-page/pull/2/files#diff-b78be019f1dc6d57753ea900c3805b114cd53ab7c0db836cc081836df1b99b7a (183)
Patch Links:
- https://github.com/atharvbarge04/Landing-page/pull/2.patch
- https://github.com/atharvbarge04/Landing-page/pull/2.diff
ā Reply to this email directly, view it on GitHub https://github.com/atharvbarge04/Landing-page/pull/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIDODC64PBKZVKKYQUXSSSLZZZC4XAVCNFSM6AAAAABPLKZG2GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU3DKNZSGE2TONI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Overview
This PR fixes the layout issues on the landing page when viewed on small screens (mobile devices).
Issue Reference
Fixes #42
Changes Made
Hacktoberfest
This PR is submitted as part of Hacktoberfest 2024. I hope this contribution helps improve the project!