search

athena-crdt / athena-core

Core conflict free replicated JSON implementation for Athena
https://athena-crdt.github.io
Apache License 2.0
3 stars 1 forks source link

feat: serializer interface with gob serialization #14

Closed Satyam6623165 closed 3 years ago

Satyam6623165 commented 3 years ago

closes #12

codecov-commenter commented 3 years ago

Codecov Report

Merging #14 (54ea262) into main (c1c4f92) will increase coverage by 2.97%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   74.58%   77.56%   +2.97%     
==========================================
  Files           6        7       +1     
  Lines         181      205      +24     
==========================================
+ Hits          135      159      +24     
  Misses         39       39              
  Partials        7        7
Impacted Files Coverage Δ
operations/defs/list_node.go 66.00% <ø> (ø)
operations/defs/map_node.go 50.00% <ø> (ø)
operations/defs/register_node.go 62.96% <ø> (ø)
operations/defs/json_node.go 93.10% <100.00%> (+0.51%) :arrow_up:
operations/serializer/serializer.go 100.00% <100.00%> (ø)
operations/lamport/clock.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1c4f92...54ea262. Read the comment docs.

bisakhmondal commented 3 years ago

Oh btw, would you like to update the serialize & deserialize methods of the JSON Node interface on this PR or on a separate PR.

Satyam6623165 commented 3 years ago

I think we can do on this PR itself

bisakhmondal commented 3 years ago

I think we can do on this PR itself

@Satyam6623165 See this: https://github.com/athena-crdt/athena-core/issues/12#issuecomment-955369530

Ig it's better to handle both the linking and refactoring on a separate PR. WDYT? We can merge this now.

Satyam6623165 commented 3 years ago

Yes . Sure