search

athena-crdt / athena-core

Core conflict free replicated JSON implementation for Athena
https://athena-crdt.github.io
Apache License 2.0
3 stars 1 forks source link

feat: crdt service (grpc) definitions & more #7

Closed bisakhmondal closed 3 years ago

bisakhmondal commented 3 years ago

This PR defines three services for different purposes

**1. OpeationService: for exchanging committed operations list (both stream & unary)

  1. HealthService: To monitor the availability of different services.
  2. DiscoveryService: Node discovery by mutually exchanging peers list to form a well-connected network starting with two nodes in a fully automated fashion.**

PS: Implementation of individual service methods will take time and will be done on separate PRs. This PR acts as a Base for all of them.

closes #1

noob77777 commented 3 years ago

@bisakhmondal 

        athena-core/operations/service.go
        Line 23: warning: exported type Service should have comment or be unexported (golint)
        Line 27: warning: exported method Service.Receive should have comment or be unexported (golint)
        Line 31: warning: exported method Service.Watch should have comment or be unexported (golint)

        athena-core/discovery/service.go
        Line 25: warning: exported type Service should have comment or be unexported (golint)
        Line 29: warning: exported method Service.Init should have comment or be unexported (golint)
        Line 33: warning: exported method Service.Watch should have comment or be unexported (golint)

        athena-core/healthz/service.go
        Line 23: warning: exported type Service should have comment or be unexported (golint)
        Line 28: warning: exported method Service.Check should have comment or be unexported (golint)
        Line 32: warning: exported method Service.Watch should have comment or be unexported (golint)
noob77777 commented 3 years ago

@Satyam6623165 use squash merge instead of merge for new pull requests

bisakhmondal commented 3 years ago

@bisakhmondal

        athena-core/operations/service.go
        Line 23: warning: exported type Service should have comment or be unexported (golint)
        Line 27: warning: exported method Service.Receive should have comment or be unexported (golint)
        Line 31: warning: exported method Service.Watch should have comment or be unexported (golint)

        athena-core/discovery/service.go
        Line 25: warning: exported type Service should have comment or be unexported (golint)
        Line 29: warning: exported method Service.Init should have comment or be unexported (golint)
        Line 33: warning: exported method Service.Watch should have comment or be unexported (golint)

        athena-core/healthz/service.go
        Line 23: warning: exported type Service should have comment or be unexported (golint)
        Line 28: warning: exported method Service.Check should have comment or be unexported (golint)
        Line 32: warning: exported method Service.Watch should have comment or be unexported (golint)

The types and methods are self explanatory!!🤡