athena-framework / athena

An ecosystem of reusable, independent components
https://athenaframework.org
MIT License
211 stars 17 forks source link

`StaticPrefixCollection` `pcre-10.43` compatiblity #359

Closed Blacksmoke16 closed 8 months ago

Blacksmoke16 commented 8 months ago

There was a nightly CI failure on windows nightly in the routing component today: https://github.com/athena-framework/athena/actions/runs/8258043654/job/22589630338. It seems there was a PCRE2 release recently and https://github.com/crystal-lang/crystal/pull/14355 was merged to upgrade windows nightly image to use this new version.

ART::RouteProvider::StaticPrefixCollection checks for a specific error message from PCRE2 that is now failing due to the error message changing as part of https://github.com/PCRE2Project/pcre2/commit/1e78b77382564b4cc9991e486652d4b105d8ee35. Can do a similar fix as https://github.com/symfony/symfony/pull/54080 to just check for both messages.