Closed Blacksmoke16 closed 1 month ago
Follow up to https://github.com/athena-framework/athena/pull/344 to leverage the new ExcludeTypeDeclarations configuration option added via https://github.com/crystal-ameba/ameba/pull/430 instead of totally disabling the rule. Allows retaining actual useless assignments without also flagging all the bundle property macro calls.
ExcludeTypeDeclarations
Lint/UselessAssign
Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title
athena-framework/athena
Context
Follow up to https://github.com/athena-framework/athena/pull/344 to leverage the new
ExcludeTypeDeclarationsconfiguration option added via https://github.com/crystal-ameba/ameba/pull/430 instead of totally disabling the rule. Allows retaining actual useless assignments without also flagging all the bundle property macro calls.Changelog
Lint/UselessAssignameba rule again but excluding type declarationsBefore merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title