athena-framework / athena

An ecosystem of reusable, independent components
https://athenaframework.org
MIT License
211 stars 17 forks source link

Make `ASPEC.assert_error` spec less strict #454

Closed Blacksmoke16 closed 1 month ago

Blacksmoke16 commented 1 month ago

Context

Makes this test a bit less strict so that it can run on multiple OSs as per: https://github.com/crystal-lang/test-ecosystem/pull/56.

Changelog


Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:x: We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Flag Coverage Δ
compiled 8.12% <ø> (ø)
unit 94.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
clock 100.00% <ø> (ø)
console 94.25% <ø> (ø)
dependency_injection 100.00% <ø> (ø)
dotenv 96.80% <ø> (ø)
event_dispatcher 94.73% <ø> (ø)
framework 95.47% <ø> (ø)
image_size 95.66% <ø> (ø)
mercure 94.63% <ø> (ø)
negotiation 98.44% <ø> (ø)
routing 94.51% <ø> (ø)
serializer 94.90% <ø> (ø)
spec 100.00% <ø> (ø)
validator 94.01% <ø> (ø)

:loudspeaker: Thoughts on this report? Let us know!