ensure athena is not relying on `en0` network device for host ip

athena-oss / athena

An automation platform with a plugin architecture that allows you to easily create and share services.

https://athena-oss.github.io/athena/

Apache License 2.0

92 stars 25 forks source link

Open savar opened 7 years ago

savar commented 7 years ago

in https://github.com/athena-oss/athena/blob/master/lib/shared/functions.os.sh#L603 the _get_host_ip_for_mac is expecting the host IP on device en0 which is not always the same. To improve this situation we should at least (thinking of IPv4/v6) go through en* and take the first private IPv4 address we find

bassco commented 7 years ago

@Savar see PR #46 for a possible solution