search

athena-oss / athena

An automation platform with a plugin architecture that allows you to easily create and share services.
https://athena-oss.github.io/athena/
Apache License 2.0
92 stars 25 forks source link

Auto-detect active mac network adaptor #46

Closed bassco closed 7 years ago

bassco commented 7 years ago

Change MAC OSX to determine IP address of active hardware port and not port en0

athena atlas up

[INFO] Checking for newer plugin version...
[INFO] Checking for newer docker images version...
shall we create a loopback IP alias (192.168.205.1) to enable PHP debugging? (yes/[no])no
[ERROR] no possible IP address for connecting from within the
        docker containers to the host was configured.. PHP xdebug
        remote debugging won't work
[ERROR] argument does not exist!

Stacktrace:
    /lib/shared/functions.argument.sh:283
    /lib/functions.docker.sh:303
    /lib/functions.docker.sh:553
    /lib/shared/functions.os.sh:125
    /lib/functions.plugin.sh:936
    /lib/functions.plugin.sh:168
    /lib/functions.plugin.sh:93
    /lib/functions.plugin.sh:44
    /usr/local/bin/athena:54

Error message should also verbosely expose ATHENA_DOCKER_HOST_IP as being empty and not just crash

savar commented 7 years ago

LGTM @pproenca @caiomoritz can you please have a second look?

thanks @bassco

bassco commented 7 years ago

@Savar Can we have this merged and released. Caught out our team again today.