search

athena-oss / plugin-php

Plugin for Test Automation using PHP as a development language.
https://athena-oss.github.io/plugin-php/
Apache License 2.0
12 stars 14 forks source link

Auto linking with proxy container combined with proxy configuration #17

Closed yael-lorenzo closed 7 years ago

yael-lorenzo commented 7 years ago

Why does the Auto linking with proxy container takes place, if I have a configuration file with a different proxy??

It is hard to say if this is a bug or misusage.

The question is why would I use a different proxy from the linking?

pproenca commented 7 years ago

Hi @yael-lorenzo-olx

You can skip the proxy auto link by providing --skip-proxy

The auto linking that takes place simply makes a hostname available inside the container, it should not affect anything else, even if you want to use a different proxy hosted in some external host.

In case you have your own implementation of a proxy and you want to use it, you can also provide the option --link-proxy=<my container name> to have the athena code link with that container, instead of the one we provide in plugin-proxy.

The reason why you would have your own implementation of a proxy server–I don't know–but that option is available for you; it makes the project flexible in case you want to do your own docker magic.

pproenca commented 7 years ago

Hey @yael-lorenzo-olx does this issue still make sense ?

yael-lorenzo commented 7 years ago

Hello Pedro! Thanks for the previous replay, I don-t remember reading it. It is a good explanation.