Please Add Support for RHEL Family (clones)

[abotelho-cbn]

Hi there, We are running AlmaLinux (not CentOS 8 or RHEL 8). Would it be possible to adjust the module to consider RHEL-clones, not hardcoded distributions?

[QA] ottvault1:~ # puppet agent -t 
Info: Using environment 'testing'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Data Provider type mismatch: Got String when a hash-like object was expected to access value using 'name' from key 'os.name' on node ottvault1.example.com
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

[QA] ottvault1:~ # cat /etc/os-release 
NAME="AlmaLinux"
VERSION="8.6 (Sky Tiger)"
ID="almalinux"
ID_LIKE="rhel centos fedora"
VERSION_ID="8.6"
PLATFORM_ID="platform:el8"
PRETTY_NAME="AlmaLinux 8.6 (Sky Tiger)"
ANSI_COLOR="0;34"
LOGO="fedora-logo-icon"
CPE_NAME="cpe:/o:almalinux:almalinux:8::baseos"
HOME_URL="https://almalinux.org/"
DOCUMENTATION_URL="https://wiki.almalinux.org/"
BUG_REPORT_URL="https://bugs.almalinux.org/"

ALMALINUX_MANTISBT_PROJECT="AlmaLinux-8"
ALMALINUX_MANTISBT_PROJECT_VERSION="8.6"
REDHAT_SUPPORT_PRODUCT="AlmaLinux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.6"

[QA] ottvault1:~ # facter os
{
  architecture => "x86_64",
  distro => {
    codename => "Sky Tiger",
    description => "AlmaLinux release 8.6 (Sky Tiger)",
    id => "AlmaLinux",
    release => {
      full => "8.6",
      major => "8",
      minor => "6"
    }
  },
  family => "RedHat",
  hardware => "x86_64",
  name => "AlmaLinux",
  release => {
    full => "8.6",
    major => "8",
    minor => "6"
  },
  selinux => {
    config_mode => "enforcing",
    config_policy => "targeted",
    current_mode => "enforcing",
    enabled => true,
    enforced => true,
    policy_version => "33"
  }
}

[abotelho-cbn]

https://github.com/athenahealth/puppet-vault/pull/6/files

This isn't even a supported OS issue, looks like collision with built-in facts.

[jeffbyrnes]

Thanks for spotting this! We actually have the same need, running Oracle Linux, so I’ll figure this out.