athenavm / athena

Athena monorepo
https://www.athenavm.org/
Apache License 2.0
21 stars 2 forks source link

No way to test guest syscall code #148

Open lrettig opened 1 month ago

lrettig commented 1 month ago

Right now this code is cfg-gated, both in the SDK:

https://github.com/athenavm/athena/blob/461e631660e869768c5b042563e227e2d09159e8/vm/sdk/src/lib.rs#L6-L18

as well as in the underlying syscode implementation:

https://github.com/athenavm/athena/blob/461e631660e869768c5b042563e227e2d09159e8/vm/entrypoint/src/syscalls/host.rs#L18-L42

The former won't even compile for the host; the latter will compile but can't be executed.

@poszu any ideas how we can allow testing of this code?

Related: #109, #107

poszu commented 1 month ago

I'm unsure, they would need to be executed in a VM. However, this code is just a few lines of raw assembly. I think we can get away with reviewing these functions "with eyes" and depending on all other tests to execute them for now.