search

athensresearch / athens

Athens is no longer maintainted. Athens was an open-source, collaborative knowledge graph, backed by YC W21
https://athensresearch.github.io/athens
Other
6.31k stars 397 forks source link

Circular embeds are crashing Athens #1125

Open snird opened 3 years ago

snird commented 3 years ago

lets say I have this:

- something here

then I reference it in a bullet indented:

- something here
  - (reference to "something here")

Athens stops responding. Of course, it doesn't make sense to use the software this way, but it happened to me by mistake and might happen to others

sawhney17 commented 3 years ago

Doesn't stop reponding for me, what version of Athens are you on and what OS are you on?

snird commented 3 years ago

beta76 on macos

yifanyin commented 3 years ago

Can confirm. Embedding its parent block in a nested block causes Athens to freeze. macOS beta78

juniusfree commented 3 years ago

Adding here for reference. Might be related issues. https://github.com/athensresearch/athens/issues/1053

sid597 commented 3 years ago

Cannot reproduce, everything works as expected beta.89. @snird @yifanyin can you please check this again in the ~latest builds?

yifanyin commented 3 years ago

Yup Athens still freezes when embedding parent block and CPU usage shoots up at the same time when parsing start. MacOS beta.89