Error in re-find query for production builds

athensresearch / athens

Athens is no longer maintainted. Athens was an open-source, collaborative knowledge graph, backed by YC W21

https://athensresearch.github.io/athens

Other

6.31k stars 398 forks source link

Error in re-find query for production builds #45

Closed jeroenvandijk closed 4 years ago

jeroenvandijk commented 4 years ago

version

all productions builds e.g. 76d0881 (artifact here)

platform

Production build, Chrome 81.0.4044.138

problem

Page doesn't load

Under water:

DevTools_-_file____Users_jeroen_Downloads_athens-app-76d0881_index_html

For some reason the ?s here in this query is not (always) a string. In dev this doesn't seem to matter or isn't the case

repro

Click on one of the page links or go to index.html#/page/04-02-2020

expected behavior

Display the page (like in dev)

tomisme commented 4 years ago

Changing to {:optimizations :simple} lets the app compile. It looks like we're including devcards and some shadow-cljs namespaces in our prod build, I think one of them is causing the issues with :advanced optimizations.

tangjeff0 commented 4 years ago

Good find @tomisme. I tried doing this here but seem to get some WebSocket error. This screenshot is from cards.html but I get the same from index.html. Probably lots of shadow-cljs stuff I don't understand.

Screen Shot 2020-07-05 at 1 38 35 PM