search

atheriel / longears

The RabbitMQ client for R
https://atheriel.github.io/longears/
36 stars 9 forks source link

Customize prefetch #12

Closed SyncM1972 closed 3 years ago

SyncM1972 commented 3 years ago

In a parallelized worker scenario, it is desirable to be able to control the number of prefetched messages per worker. For this, the constant number of 50 prefetched messages can be modified by an additional prefetch_count parameter.

atheriel commented 3 years ago

Thanks, this is a nice and clear change. Can you please do the following?

  1. Remove the unrelated changes to the DESCRIPTION and .gitignore files.
  2. Move the NEWS entry into the longears 0.2.4.9000 section (below the existing entry) and use the existing format (indented, sentence case, 80 columns).
  3. Squash your changes into a single commit with a single commit message.
SyncM1972 commented 3 years ago

Thank you for your comments. I have performed the requested operations.

atheriel commented 3 years ago

The changes look good. It looks like the commit changes permissions on cleanup and configure, though, which is almost certainly a mistake.

SyncM1972 commented 3 years ago

The permissions are corrected.

atheriel commented 3 years ago

I merged this manually in 606573c. Thanks!