search

athieriot / drone-artifactory

Drone plugin for publishing build artifacts to Artifactory
Apache License 2.0
10 stars 12 forks source link

Add ability to use a package.json for node applications #14

Closed dstgermain closed 4 years ago

dstgermain commented 8 years ago

This enables the use of package.json files to define attributes. Removed Pom file functionality and Package file from check_params to decrease the cyclomatic complexity.

athieriot commented 8 years ago

Hi @dstgermain,

Thank you so much for your work, I was really curious to know how other kind of binary would work with that plugin.

I am going to add a few comments that are mostly aesthetic but it looks great (Nice tests !)

One other thing that would be nice for you to do if you don't mind, is to add a few lines about that feature in the DOCS.md file. So it can be picked up in the website.

dstgermain commented 8 years ago

I was about to add to the md when I got distracted. I'll Add those changes and update the md. Do you prefer squashed commits?

athieriot commented 8 years ago

That would be great if you can squash your commits yeah.

The change is pretty concise so it's probably clearer that way :)

athieriot commented 8 years ago

Ola ! Just wanted to know how you are going along with that.

You are so close it would be a shame not to merge your work !