search

athieriot / drone-artifactory

Drone plugin for publishing build artifacts to Artifactory
Apache License 2.0
10 stars 12 forks source link

Support Drone 0.5 #19

Closed k0nserv closed 6 years ago

k0nserv commented 6 years ago

The previous support for Drone 0.5 did not actually work. This was because the drone-node plugin was being instatniated regardless of node version which fails since it tries to parse the input JSON.

k0nserv commented 6 years ago

cc @athieriot

athieriot commented 6 years ago

Excellent thanks !

k0nserv commented 6 years ago

Build fails, not entirely sure what's happening there

k0nserv commented 6 years ago

Fails on master for me as well

k0nserv commented 6 years ago

I think some of the mocking by nock might be failing

athieriot commented 6 years ago

Might be, be all the tests seem to pass:

https://beta.drone.io/athieriot/drone-artifactory/29/3

It even shows a good coverage...

k0nserv commented 6 years ago

Right so could we merge anyway then? It'd be great if this could be released as it blocks me with what I'm currently trying to do

athieriot commented 6 years ago

Sorry if it's rude but I need to ask: Did you try it on your Drone instance? (I might require a digital blood signature)

k0nserv commented 6 years ago

This fix? No I didn't, but I debugged it and found that the error I saw was related to the invocation of const plugin = Drone.Plugin() which causes the JSON parsing to kick in and subsequently fail

athieriot commented 6 years ago

Don't hesitate to come back with another PR if you're blocked again.

k0nserv commented 6 years ago

Thanks, I guess there's a risk that it will not publish due to the tests failing however

k0nserv commented 6 years ago

Yes that is indeed what happens. I'll have a look and see if I can't resolve that.

k0nserv commented 6 years ago

Resolved in https://github.com/athieriot/drone-artifactory/pull/20