search

athieriot / drone-artifactory

Drone plugin for publishing build artifacts to Artifactory
Apache License 2.0
10 stars 12 forks source link

[Dependencies] Upgrade nock #20

Closed k0nserv closed 6 years ago

k0nserv commented 6 years ago

This resolves the build errors. I also added package-lock.json to ensure deterministic builds

athieriot commented 6 years ago

Wow that was quick

Nice one ! Thanks.

k0nserv commented 6 years ago

Still fails though :(

tboerger commented 6 years ago

coverage and publish will anyway always fail... coverage is dead and publish is missing all secrets.

athieriot commented 6 years ago

Damn. I've been away for a long time it seems

k0nserv commented 6 years ago

Strange that make test works well locally though

k0nserv commented 6 years ago

Upgraded to node lts for the build step which resolved that issue. @athieriot I assume both the coverage and publish steps will fail on master though?

athieriot commented 6 years ago

I'll see what I can do about that.

If I don't find the time to fix it properly I can still push the image manually for now

On 16 November 2017 at 14:20, Hugo Tunius notifications@github.com wrote:

Upgraded to node lts for the build step which resolved that issue. @athieriot https://github.com/athieriot I assume both the coverage and publish steps will fail on master though?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/athieriot/drone-artifactory/pull/20#issuecomment-344936245, or mute the thread https://github.com/notifications/unsubscribe-auth/AAoZjSnXq2j-EIpLBgbfVhrAgJbH_BR2ks5s3ESpgaJpZM4Qgg0N .

k0nserv commented 6 years ago

That'd be awesome thanks :)

athieriot commented 6 years ago

So I don't understand how it's working but Drone don't pick up the Registry I've set up there.

I've pushed the latest master manually in the Registry in the meantime