search

athieriot / hubot-yammer

This is the Yammer adapter for hubot that allows you to send a message to him with Yammer and he will happily reply the same way.
31 stars 26 forks source link

Hubot help don't work well. Overflow issue #2

Closed athieriot closed 11 years ago

athieriot commented 12 years ago

The "help" script doesn't work correctly because of a large overflow of request to the Yammer API.

That should be detected but I don't really know how to handle it.

rantav commented 11 years ago

I get that as well. Would love to see a fix for this. I think it's also going to present a problem for me in another context.I want hubot to execute deployment scripts and their output can become very long, so I suppose they will fail in the same way as the help command fails.

rantav commented 11 years ago

It seems that https://github.com/athieriot/hubot-yammer/pull/8 also inadvertently fixes this issue. Now when replies are used, the length limit seem to had been removed. I haven't seen any documentation on that from yammer but experimentation shows it does... try bot help and see...

athieriot commented 11 years ago

Oh crap I respond to that in the other PR :)

athieriot commented 11 years ago

Seems to be fixed by: https://github.com/athieriot/hubot-yammer/pull/3

Need to work on the design though