athieriot / hubot-yammer

This is the Yammer adapter for hubot that allows you to send a message to him with Yammer and he will happily reply the same way.
31 stars 26 forks source link

Provide NPM deployment facility which leverage Travis CI #23

Closed athieriot closed 8 years ago

athieriot commented 8 years ago

You've been ahead of me with your PR :p (https://github.com/StackStorm/docker-hubot/pull/9) but I prepared something that should be practical for both of us (I hope).

It probably won't work the first time but it's worth the try anyway. In a nutshell, Travis CI is able to publish to NPM is behalf of somebody and you can configure it so it does it everytime someone is pushing a new Git tag.

So this Pull Request provide the relevant Travis CI step + a convenient gulp task to bump the version number. Running:

  gulp release

Will prompt you with a few choice of version increment strategy (minor, major, patch) or you can enter a manual number compatible with semver. Then:

Currently you have to push the tag manually (This can also be automated) but I figured this would be acceptable:

  git push --tags

I know it's not as nice for you as having direct access on NPM but it gives me some insurance over what repository is deployed on NPM at least.

And hopefully this gives you more freedom with the releases (Instead of using the master branch directly) and to be honest the gulp task is nice for me too :p

athieriot commented 8 years ago

LGTM

emedvedev commented 8 years ago

Hey, that looks just perfect. If it works and we can push releases, I don't really need npm access anymore. Let's test-drive it through a couple version bumps and then maybe I can revert that docker-hubot PR (that would be awesome, since just using master branch is suboptimal for multiple reasons).

Thanks a lot for this, and I'm really glad this solution works for you!

emedvedev commented 8 years ago

LGTM

athieriot commented 8 years ago

Ah. Needs LGTM again after new changes :)