Closed emedvedev closed 8 years ago
1) You are right. If you feel better that way you can remove hubot
depdency and add it later if it's need for unit tests
2) It use to be used by the yammer
library included in the source (Reference: https://github.com/athieriot/hubot-yammer/commit/738b72649927c047be2e873891d5bf423ea09594#diff-25d80a6e8a40393e836b15f145a2ff8dL1)
3) I now there is no 3 :p But what would you think of cleaning up the main
property of the package.json
and upgrading engine
version of Node.js (That's up to you though, not sure if it makes any difference)?
If you could just squash those two commits together I'll approve it.
P.S: Sorry for the delay ! We are not quite in the same timezone (I'm on Europe/London so your morning should be my afternoon) :p
Hm, yeah, I'll clean it up and see if I can upgrade Node. Will get back to you on that. Don't worry about the delay :)
Checked the comment out, I don't think we can remove 'main' for coffeescript at all, and node version is fine. Up to you if you want to change anything else while we're at it. :) LGTM
Up to you :) Was just a comment. If you're fine with that.
I would definitively squash your two commits together though
Done. LGTM
LGTM
hubot-yammer
doesn’t “depend” onhubot
in the package.json sense, it’s the other way around. :) It’s a dev-dependency at best (hubot-slack
lists it in dev,hubot-hipchat
doesn’t list it at all), and installing inside a docker container with a hubot dependency is suboptimal because it’ll fetch hubot the second time.request
in the code, so I’m removing it. @athieriot: need your input here, you might know something I don’t. :)