search

athityakumar / colorls

A Ruby gem that beautifies the terminal's ls command, with color and font-awesome icons. :tada:
MIT License
4.83k stars 379 forks source link

Auto-completion for fish shell #163

Open athityakumar opened 6 years ago

athityakumar commented 6 years ago

Description

The auto-completion for flags and paths can be provided for the fish shell via the getopt plugin.

dkowis commented 6 years ago

https://fishshell.com/docs/current/commands.html#complete

This is probably a better idea than using the getopt plugin? That way no extra plugin has to be installed, I think.

SpaceWhite commented 6 years ago

+1 for this feature

adcpe commented 1 year ago

This issue is interesting to me. I agree that adding completions to Fish natively would be better than adding them through an external plugin.

To do that we have to add this feature to Fish directly. I see PR 179 has a template of what would be added. Is that still good or does it need to be modified to be added to Fish?

dkowis commented 1 year ago

I don't think it needs to be added directly to fish. I think you just need to provide the completions file to be loaded.

https://fishshell.com/docs/current/completions.html#completion-own

It's been a long long time since I looked at this tho, heh

adcpe commented 1 year ago

It doesn't need to be added Fish, but it would be the best way because it means the user doesn't have to make any effort.

The other way would be add a command to colorls that copies the completions to $HOME/.config/fish/completions/.

Any of the two seem cleaner than adding an external plugin like getopt, as suggested.