Open olirwin opened 1 year ago
Patch coverage: 100.00
% and project coverage change: +1.03
:tada:
Comparison is base (
5e0b25a
) 90.86% compared to head (fdcd93c
) 91.89%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thank you @olirwin!
The tests failed, can you fix them?
Thank you @olirwin!
The tests failed, can you fix them?
Fixed as much as I could understand (there were 2 failing tests, one due to linter warnings, the other to test coverage). I am not in a position to write tests for this change in code.
The other tests were just being auto cancelled.
Solved this: add support for files with no extension #577 and: Fixes Icons for files without extenstions #459 Relates to Icons for file with only one extension #469
tests:
bundle exec rubocop
bundle exec rspec
test/run
finished OK
Here you can see dot-files with icons and file without extension with icon, and also can be file only from dots:
how to assign it to me ? and make me permission to commit branch and PR ?
Description
Updated the way the key is computed to allow for files without an extension to get icons.