athom-tech / athom-configs

Athom Technology Official Center
MIT License
190 stars 127 forks source link

Update athom-smart-plug-v2.yaml #43

Closed dexn closed 4 months ago

dexn commented 4 months ago
Roving-Ronin commented 4 months ago

@dexn "Reverted "WiFi Strength" %, Home Assistant only accepts dB or dBm" ????

HA has no problem with using that sensor, it just sees it as a number (with the % as the unit measurement / type). Been running fine in HA for over a year with it.

image


"current_limit : 16 # Current Limit in Amps. AU Plug = 10. IL, BR, EU, UK, US Plug = 16."

There was a 10A version of the v2 plug, that iirc a year ago got replaced with a 16A version. So how would this work with 10A versions being told to work at 16A ?

In Australia also its a 20A circuit for GPO's, with up to 10 outlets upon that circuit, not 10A max.


Re removing 'Device' from the sensor name, if doing this you start getting these sensors populating all over the ESP web interface, versus having them grouped up.

Same for the Reset / Restart, would suggest at least using 'Reset Factory' that would keep this sensor at the bottom of web interface with 'Restart'

Roving-Ronin commented 4 months ago

@tarontop Aiden, IMHO that was a bit rushed, 1 hour and pushed. Allowing time for peer review and feedback (see above) would be good.

??

tarontop commented 4 months ago

All our plugs are equipped with 16A relay as standard, including the Australian version, so there is no problem in theory with the hardware, we claim 10A just to pass the certification

Roving-Ronin commented 4 months ago

@tarontop Ah OK re Amps, makes sense to use that.

Would still query as above, re changing WiFi to Db that means nothing for most users, versus a % system that everyone can understand. Doing this as one person claims it doesn't work, when it in fact does work fine in HA (in use over a year) as demonstrated above.

Also suggest any changes getting submitted start using versioning, i.e. Project version is just 2.0, but with all these changes it should be being updated for each update. So by now we'd be looking at least 2.1.x with all these updates. Doing this makes it much easier for users to check installed vs published code and decide if they want to update, without having to check the actual yaml code.

https://en.wikipedia.org/wiki/Software_versioning

tarontop commented 4 months ago

@tarontop Ah OK re Amps, makes sense to use that.

Would still query as above, re changing WiFi to Db that means nothing for most users, versus a % system that everyone can understand. Doing this as one person claims it doesn't work, when it in fact does work fine in HA (in use over a year) as demonstrated above.

Also suggest any changes getting submitted start using versioning, i.e. Project version is just 2.0, but with all these changes it should be being updated for each update. So by now we'd be looking at least 2.1.x with all these updates. Doing this makes it much easier for users to check installed vs published code and decide if they want to update, without having to check the actual yaml code.

https://en.wikipedia.org/wiki/Software_versioning

ok thanks we will do that

dexn commented 4 months ago

Would still query as above, re changing WiFi to Db that means nothing for most users, versus a % system that everyone can understand. Doing this as one person claims it doesn't work, when it in fact does work fine in HA (in use over a year) as demonstrated above.

@Roving-Ronin Sorry. It does seem to work now. For some unknown reason last month, my HA was saying it was an incorrect unit of measurement for wifi signal. I've updated since and that issue is resolved, so I don't know where my issue was caused.

Also with our Australian power, we have 20A circuits but 10A sockets.