search

athombv / homey-apps-sdk-issues

This issue tracker is for Homey Developers using the Apps SDK.
21 stars 4 forks source link

Trigger card automatically created/derived from app code (not custom flow triggers) but Homey firmware based trigger card #344

Closed jtebbens closed 6 months ago

jtebbens commented 6 months ago

I am developer for HomeWizard app and the trigger cards that are created by Homey itself (so not a custom card in my app) seems not to trigger. Added screen shot shows example of those that don’t seem to hit at all.

Example is for voltage (see screencapture from community forum. Voltage triggered card is created automatically from Homey OS/firmware based on capability that comes from the P1 driver code but is not a custom trigger developed me.

image

Link to post https://community.homey.app/t/app-pro-homewizard/19267/1411?u=jeroen_tebbens

RobinBol commented 6 months ago

Hi @jtebbens, that is strange, can you provide a minimum reproduction so we can verify the bug is cause by Homey and not your app? By the way, from the forum post, I can't conclude that the voltage value actually changed to a value higher than 250 or lower than 220 (note it must exceed the threshold before the Flow card triggers).

jtebbens commented 6 months ago

Hi @RobinBol, thanks for you reply. I haven't replicated myself (yet) but pretty sure my app user Theo de Koning did as per screenshot. I just raise it on his behalf as its not a trigger card my code controls at all. Its derived from the measure_voltage.l1 per P1 energy driver. Let me try to replicate it myself as well.

jtebbens commented 6 months ago

Alright, tested myself now and it does work (as designed of course). Only the event or moment triggers the card not ever pull of data of the device and check. Havent tested it yet with a variable that is updated on the fly (like max volt a d reset with newer max volt). IMG_0889 IMG_0678 IMG_0888

RobinBol commented 6 months ago

That is great! Not sure what you mean with this exactly though: "Only the event or moment triggers the card not ever pull of data of the device and check. Havent tested it yet with a variable that is updated on the fly (like max volt a d reset with newer max volt)."

This issue can be closed?

jtebbens commented 6 months ago

I mean the passing moment of the volt value going from x < 238v -> x > 238v. Af that if x is still higher than 238v nothing will trigger next time until it drops below 238v and that condition is reset and card will trigger again when that moment happens again.

Yes will close.

RobinBol commented 6 months ago

I see, that is correct indeed. That is how those cards are meant to work.

jtebbens commented 6 months ago

One last comment/question on this. What if that variable is changing. So instead of a hardcoded 238v in my example. But a custom variable that holds the value 238, then in the flow it updates from 238 to 239. Does that active condition in the first card that holds that variable card (which now is not 238 but 239). Would it then trigger or does the flow need to be stopped/started to reset that condition?

RobinBol commented 6 months ago

I am not 100% sure to be honest, I believe it is best to use static values as input for trigger cards.