search

athombv / org.knx

KNX for Homey
0 stars 2 forks source link

Save interfaces to the settings object, and try to restore on app load. #18

Closed petero-dk closed 1 month ago

petero-dk commented 1 month ago

That way connections for interfaces that will not be found by lookup, will restart on app load. I have this problem, and I have seen other people on the forum with this problem.

petero-dk commented 1 month ago

@ttherbrink I was not able to assign you as a reviewer, I think this is done. It solves the issue on having interfaces that does not respond to the UDP lookup. So when I manually add it to a device (which works just fine now) it will auto try to reconnect on startup.

It will not fix EVERY issue, if the interface changes ip after restart then it will not work.

For now this would allow people with a knx setup that does not function on UDP broadcast to set a static ip to their device and have it work very stable.

petero-dk commented 1 month ago

I will just pause and breathe for a day or two, because switching branches that start depending on the cleanup, and the small changes in this PR is getting a little crazy. Do you have any idea on how long time PR's like this one and #17 would take for you to review and approve?

Thank you for lettings us contribute.

petero-dk commented 1 month ago

Functionality seems to be working. The error cases might occur when all the KNX interfaces are offline.

It should at least not fail more than previously now. I added error handling to that part. If all interfaces are offline, there is not much to do.

petero-dk commented 1 month ago

❤️