search

athrowaway2021 / comix

Seamlessly download and de-drm comics and manga from Kindle in highest possible quality
MIT License
61 stars 20 forks source link

Script does not handle MFA well #51

Closed BakaUshi closed 8 months ago

BakaUshi commented 8 months ago

If you have MFA enabled, the first login using email + password will fail but then you should get the text message, and you need to reenter email + password concatenated with the 6 digit code. I confirmed this works. We should be able to handle this more elegantly - not sure if the login failure has any code that indicate MFA is enabled or not, if so, we can prompt for the MFA code and add it to the PW. We need to make sure that if we're caching the PW for future sessions to store the version that does not concatenate with the MFA code.

(I might mess with trying to get this to work properly)

athrowaway2021 commented 8 months ago

Fixed in 7d03caf

The tool will now check if OTP is required after an attempted login, ask for the OTP, and reattempt seamlessly.

BakaUshi commented 8 months ago

appreciate your work on this - I also fixed it on my side, but wasn't able to submit my branch, but since you got it, we're all good