search

athul / archie

A minimal Hugo Theme
https://athul.github.io/archie
MIT License
975 stars 301 forks source link

Minimal dark mode #30

Closed RobbiNespu closed 2 years ago

RobbiNespu commented 3 years ago

Ref: https://github.com/RobbiNespu/archie/pull/4/files

Minimal dark mode archie #13

RobbiNespu commented 3 years ago

Hi @athul , yes as mentioned on #13 , it for using light mode manual or light mode auto, the toggle will be visible.

there is only 1 icon which is fa-sun for both. Even though the icon name "sun" , It look like lamp to me. If you check the setTheme() funtion, I try replace icon with toggle.className but seem it not work. (that is where I left console.log) , maybe you or anyone can take alook?

But nevertheless , what I need is archive but it not likely a properly work and what people expected.

Someone else need to take care it. I not good with JS. You can give me change suggestion if you found the answer or just edit the commit and make changes

athul commented 2 years ago

Hey, @RobbiNespu sorry I couldn't look more into it. I really am. But had to merge #36 since it was more concise and lesser code. Hope you can understand.

Thanks for the PR and wishing you good luck 🤝

RobbiNespu commented 2 years ago

Hello @athul , it fine. I am okey to close the PR #30. I also agreed PR #36 it was more concise and lesser code, perhaps much cleaner. Thanks for mention and wishing you good luck too 🤝

(Originally published at: https://robbinespu.gitlab.io/indieweb/2021-09-29-0000-comment-github-archie/)