search

athul / waka-readme

Wakatime Weekly Metrics on your Profile Readme.
https://github.com/athul
MIT License
1.56k stars 302 forks source link

Custom section name in user readme #110

Closed guilyx closed 1 year ago

guilyx commented 1 year ago

Basically, allow any other section name tag than "waka" in the readme, to avoid conflicts with other projects that may use the same default one. I'll do the same PR for the other one...

Currently testing.

guilyx commented 1 year ago

@athul

yozachar commented 1 year ago

@guilyx, thanks for the PR! It's a good idea.

But can you please re-do the PR with just one commit, since the changes are small and perfectly focused for one commit? Also add relevant notes to to the Readme's #tweaks section.

Thanks!

"Currently testing."

If so, mark your PR as draft.

guilyx commented 1 year ago

Hey, actually marked it as WIP and then edited it out - testing is done atm. Annnnd why don't you just Squash and Merge ? Not an option ? Will do the readme thing

guilyx commented 1 year ago

@joe733 Squashed all the commits in one and updated readme :)

guilyx commented 1 year ago

Hey again @joe733 Made it cleaner, added an input validation etc

yozachar commented 1 year ago

Ah, thank you. But it was a note-to-self. Now it might require more changes. Let me review.

yozachar commented 1 year ago

I do want to make changes, but for now let it be.