search

athul / waka-readme

Wakatime Weekly Metrics on your Profile Readme.
https://github.com/athul
MIT License
1.53k stars 301 forks source link

(feat): option to hide time #67

Closed lucassabreu closed 2 years ago

lucassabreu commented 2 years ago

SHOW_TIME will increase the size of the graph, and hide the text string with the amount of time.

I like to see the distribution of time in each language, but sometimes the time string itself is a bit misleading because of time spent browsing for solutions. So I would like to add this option to hide it in the graph.

I already used this on my profile: https://github.com/lucassabreu/lucassabreu/blob/main/README.md

Looking at my graph you will see I don't use python a lot, so tell me if the code does not feel "python" in the end.

lucassabreu commented 2 years ago

this change won't affect #57, the json field still there, it is just hidden.

there is another integer field with the amount of seconds the text field represents, probably we should use that there i think.

By the way I think WakaTime handles that, it pauses the timer when there's a break in coding activity.

I know that, but I think it should count towards it when I am researching something about PHP for example, but wakatime doesn't have access to my internet history, and even so would be almost impossible to know if I am looking for PHP stuff, or just looking at memes.

yozachar commented 2 years ago

Okay, I won't have them count towards my coding activity, but then that's personal choice.. :) Everything else looks good to me @athul

@lucassabreu would you please fetch and merge updates from upstream, before merging this PR?

lucassabreu commented 2 years ago

just rebased it @joe733

athul commented 2 years ago

Merged. Thanks @lucassabreu 🎉