atifaziz / gurtle

Google Code project issue tracker integration for TortoiseSVN & TortoiseGit
https://code.google.com/archive/p/gurtle
0 stars 0 forks source link

Wrong encoding in Issues list (like ěščřžýá) #27

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. site http://code.google.com uses UTF-8
2. issues displays text in ANSI
3. text is broken

What is the expected output? What do you see instead?
issues should display ěščřžýá as it is shown on site

What version of the product are you using? On what operating system?
TortoiseSVN 1.6.1 (EN), Windows XP Czech

Original issue reported on code.google.com by digiqr on 16 Apr 2009 at 11:21

GoogleCodeExporter commented 8 years ago

Original comment by azizatif on 18 Apr 2009 at 9:21

GoogleCodeExporter commented 8 years ago
Additional information...

Using:

wget -O- --debug http://code.google.com/p/xtlib/issues/csv

Response indeed indicates UTF-8:

Content-Type: text/csv; charset=UTF-8

Full Wget debug output was:

DEBUG output created by Wget 1.10 on Windows.

--23:21:27--  http://code.google.com/p/xtlib/issues/csv
           => `-'
Resolving code.google.com... seconds 0.00, 74.125.43.113, 74.125.43.100, 
74.125.43.101, ...
Caching code.google.com => 74.125.43.113 74.125.43.100 74.125.43.101 
74.125.43.102
Connecting to code.google.com|74.125.43.113|:80... seconds 0.00, connected.
Created socket 304.
Releasing 0x002a1078 (new refcount 1).

---request begin---
GET /p/xtlib/issues/csv HTTP/1.0
User-Agent: Wget/1.10
Accept: */*
Host: code.google.com
Connection: Keep-Alive

---request end---
HTTP request sent, awaiting response...
---response begin---
HTTP/1.0 200 OK
Date: Sat, 18 Apr 2009 21:21:24 GMT
Pragma: no-cache
Expires: Fri, 01 Jan 1990 00:00:00 GMT
Cache-Control: no-cache, must-revalidate
Content-Disposition: attachment; filename=xtlib-issues.csv
Content-Type: text/csv; charset=UTF-8
X-Content-Type-Options: nosniff
Set-Cookie: 
PREF=ID=458a7c6629b607dc:TM=1240089684:LM=1240089684:S=BGoVIRiTCfCfsIEi; 
expires=Mon, 18-Apr-2011 21:21:24 GMT; path=/; domain=.google.com
Server: codesite

---response end---
200 OK
cdm: 1 2 3 4 5 6 7 8
Stored cookie google.com -1 (ANY) / <permanent> <insecure> [expiry 2011-04-19 
00:21:24] PREF 
ID=458a7c6629b607dc:TM=1240089684:LM=1240089684:S=BGoVIRiTCfCfsIEi
Length: unspecified [text/csv]

Closed fd 304
23:21:27 (3.44 MB/s) - `-' saved [351]

Original comment by azizatif on 18 Apr 2009 at 9:30

GoogleCodeExporter commented 8 years ago
This issue seems to be due to an oversight in WebClient.DownloadString(Async). 
Although it is documented to use WebClient.Encoding to convert the downloaded 
bits 
into a Unicode string, it should also be paying attention to the character set 
of 
indicated in the response header.

Original comment by azizatif on 18 Apr 2009 at 9:48

GoogleCodeExporter commented 8 years ago
Fixed in r115.

Original comment by azizatif on 18 Apr 2009 at 10:26