search

atigyi / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
0 stars 0 forks source link

samples: net: google_iot_device: bsp: iotc_bsp_io_net_zephyr: Use bar… #9

Closed pfalcon closed 5 years ago

pfalcon commented 5 years ago

…e constants POLLIN/POLLOUT/POLLERR.

The rest of this file uses bare POSIX names, not "zsock_" prefixed variants, so it only makes sense to do the same for these constants.

And next step of porting the sample to native Zephyr targets is to enable POSIX subsystem (CONFIG_POSIX_API), which only exports standard POSIX name, so it's required for it too.

This changes should be squashed into the original commit introducing iotc_bsp_io_net_zephyr.c.

Signed-off-by: Paul Sokolovsky paul.sokolovsky@linaro.org

pfalcon commented 5 years ago

@atigyi: As the commit message suggest, feel free to squash this into the related commit right away. Otehrwise, we'll need to do that later. Thanks!

atigyi commented 5 years ago

@pfalcon: Did the git squash into the commit where the file in question was introduced, please check the commit history.

pfalcon commented 4 years ago

@atigyi : Thanks! Looks good from first look, will look in more detail tomorrow. Btw, I by habit say "squash", but when you do git rebase --interactive, it oftentimes makes sense to select "f" aka "fixup" action instead "squash". "squash" combines 2 commit messages (and allows to edit), while "fixup" keeps commit message of first commit. It's not a big deal anyway, we'll be squashing more stuff around, and will clean up commit messages at the end.

atigyi commented 4 years ago

Great news! + :) 👍 Yes, I saw the combined commit messages, still learning the preferred git history structure.

pfalcon commented 4 years ago

@atigyi: Sounds good ;-). And just to confirm, everything indeed looks well, and I tested the latest google_iot_device_sdk_integration branch with native_posix (I'm sure you did either, just trying to be explicit about that, so we could trace regressions if they appear).

atigyi commented 4 years ago

@pfalcon Thanks for testing. Yes, I did the tests as well. What does Zephyr do to provide QA for samples? Continuous build at least I guess. Is there anything else?

pfalcon commented 4 years ago

@atigyi: Yes, there's CI, which builds stuff (a subset on each related PR, whole (and that's a lot) by cron). Where possible, stuff is also run in qemu_x86 (and other qemu's). But that concerns only small part of networking-related tests (unittests and stuff which can be run locally via loopback).

It's ongoing theme of our (Linaro's) work to be able to test things on real hardware, but in regard to networking testing, we're at the about same stage.

We however have some CI for bigger Zephyr projects (scripting language ports - MicroPython, JerryScript, Zephyr.js), and perhaps could set up a similar adhoc test for Google Cloud, based on (suitably modified) sample app. But again, networking set up (all the firewalls, NATs, DNSes, etc.) is a challenge as well as reliability. That's definitely something to discuss on Linaro/Google level after we complete the initial porting work.