atilaneves / automem

C++-style automatic memory management smart pointers for D
BSD 3-Clause "New" or "Revised" License
86 stars 15 forks source link

Fix incorrect `escape.element` test #72

Closed dkorpel closed 1 year ago

dkorpel commented 1 year ago

Blocking https://github.com/dlang/dmd/pull/14871

There's no transitive scope, the return scope opIndex() method on a scope struct Vector protects pointers into the underlying scope E[] _elements;, but not the pointer values of the array elements themselves.

codecov[bot] commented 1 year ago

Codecov Report

Base: 98.58% // Head: 98.58% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (ba70a01) compared to base (e418d37). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #72 +/- ## ========================================== - Coverage 98.58% 98.58% -0.01% ========================================== Files 12 12 Lines 851 850 -1 ========================================== - Hits 839 838 -1 Misses 12 12 ``` | [Impacted Files](https://codecov.io/gh/atilaneves/automem/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Atila+Neves) | Coverage Δ | | |---|---|---| | [tests/ut/vector.d](https://codecov.io/gh/atilaneves/automem/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Atila+Neves#diff-dGVzdHMvdXQvdmVjdG9yLmQ=) | `99.22% <100.00%> (-0.01%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Atila+Neves). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Atila+Neves)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dkorpel commented 1 year ago

Ping @atilaneves

dkorpel commented 1 year ago

@atilaneves Can you add a new tag? Buildkite is still checking out v0.6.8

atilaneves commented 1 year ago

Done.