search

atim-radiocommunications / armapi

API for ARM module
MIT License
7 stars 18 forks source link

impossible condition in arm.cpp #5

Closed malocharo closed 7 years ago

malocharo commented 7 years ago

Hi, there is an impossible condition line 1672 of the file arm.cpp

//Check if out of range if((nbFrame > 15) && (nbFrame < -15)) return ARM_ERR_PARAM_OUT_OF_RANGE;

nbFrame cannot be higher than 15 and lower than -15 at the same time. I suppose it should be this instead:

//Check if out of range if((nbFrame > 15) || (nbFrame < -15)) return ARM_ERR_PARAM_OUT_OF_RANGE;

Thank you anyway for this API

antoine163 commented 7 years ago

Exactly, Thank for your feedback.