search

atinux / node-ftps

FTP, FTPS and SFTP client for node.js, mainly a lftp wrapper.
MIT License
202 stars 57 forks source link

FIX: do not escape special characters on user and password #70

Open scipioa opened 6 years ago

scipioa commented 6 years ago

User and password fields are already between quotes: add the escape character '\' gives wrong password or username.

MichielMag commented 3 years ago

Hello @scipioa , this is a long shot since you posted this pull-request a few years ago, but are you still interested in applying this change? If you do might I suggest to use strong quoting?

scipioa commented 3 years ago

Hi @MichielMag , Yes, this change is still relevant. I don't really see the point of using strong quoting. This commit was used in production and worked fine.

MichielMag commented 3 years ago

Hey Scipioa, thanks for responding! The reason I suggested strong quoting is because your fix only fixes one edge case. A problem like #81 would still happen. I think strong quoting tackles both issues.

atinux commented 2 years ago

Open for a more agile solution