search

atinux / node-ftps

FTP, FTPS and SFTP client for node.js, mainly a lftp wrapper.
MIT License
203 stars 57 forks source link

Disabling shell-escaping? #81

Open DuimTechniek opened 3 years ago

DuimTechniek commented 3 years ago

I was debugging a problem I had with files not uploading, and in the end it turned out to be an incorrect password. I had a password with a "$" in it which was escaped to "\\$". For testing I just disabled the escape entirely by returning the command without escaping and suddenly my files were uploading.

This means that in my specific situation it turned out that the "$" didn't need to be escaped at all.

My question is: is escaping needed at all? And if it is, may I suggest an option to disable escaping? I'd be happy to implement that and make a PR.

DuimTechniek commented 3 years ago

I see there is already a PR open for almost 2.5 years describing my problem: https://github.com/Atinux/node-ftps/pull/70