atipugin / telegram-bot-ruby

Ruby wrapper for Telegram's Bot API
https://core.telegram.org/bots/api
Do What The F*ck You Want To Public License
1.35k stars 217 forks source link

Return corresponding types for API methods #285

Closed AlexWayfer closed 1 year ago

AlexWayfer commented 1 year ago

Don't touch Api#call, leave it with raw responses, but convert result in method_missing.

Resolve #284

Resolve #286 now too.

And #278 too.

AlexWayfer commented 1 year ago

I've figured out that CI secret token is empty, that's why tests are failing: https://github.com/atipugin/telegram-bot-ruby/pull/287#issuecomment-1637675344

AlexWayfer commented 1 year ago

I'm waiting your decision about ENDPOINTS constant, also you might be interested in new Types::CHAT_MEMBER decision, and I suggest to merge #287 (with successful CI) before this one: then I will record requests and we'll get green CI here too.

AlexWayfer commented 1 year ago

Added VCR changes from master, added cassettes for changed specs — now CI is green. :clap: