search

atishelmanch / flashgg

https://twiki.cern.ch/twiki/bin/viewauth/CMS/FLASHggFramework
0 stars 3 forks source link

HHWWgg Full-leptonic #3

Closed chuwang1 closed 4 years ago

ram1123 commented 4 years ago

Hi @chuwang1 ,

I have one general comment. Please delete all the executable files from commit.

We generally add a .gitignore file in the main directory of any repository. And add the files or extension of files that we don't want to comment. You can read more about it here.

We also have a .gitignore file in our repository in our directory. I can see in our .gitignore and it excludes *.pyc files. But, I can see the committed *.pyc files this suggest that you added them by force. We should be very careful about using -f option in git. We can chat offline about the details.

with regards, Ram

ram1123 commented 4 years ago

@chuwang1

One more thing. I think somehow you used older and newer information both and they are merged.

I can also see the directory NtupleAnalysis in your repository. @atishelmanch moved it into another repository (https://github.com/NEUAnalyses/HHWWgg_Tools). I think you should also delete this.

atishelmanch commented 4 years ago

I agree with both of @ram1123 's comments. Thanks.