search

atk4 / api

Implementation of RestAPI for Agile Data
https://agiletoolkit.org/
14 stars 12 forks source link

drop versions below PHP 7.2 #19

Closed abbadon1334 closed 5 years ago

abbadon1334 commented 5 years ago

i think this must be done

DarkSide666 commented 5 years ago

Why not support PHP 7.0 and 7.1 ?

abbadon1334 commented 5 years ago

Why not support PHP 7.0 and 7.1 ?

because of this : https://www.php.net/supported-versions.php, prior of this i see that atk4/data drop support for php below 7.2.

We can leave this to support >7.0 and let composer resolve requirements if used with other packages.

I open this issue while I was showing to one of my dev the library and i see that it was required 5.6. After that i see yours on same subject but with drop for 7.0 and i decide to leave it open.

DarkSide666 commented 5 years ago

Yeah, probably you're right about 7.2. If data don't support php <7.2, then it's useless to try to run api on 7.0 or 7.1.

Please also add fix for travis.yml (remove 7.0, 7.1 and maybe add 7.3) and let @romaninsh decide what to do with this.

abbadon1334 commented 5 years ago

@romaninsh in travis i removed the lines targeting php version for coverage, please check it.

DarkSide666 commented 5 years ago

@abbadon1334 Why did you remove code coverage sending? I think it was fine, just needed to change 7.0 to 7.2.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@c1a595c). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #19   +/-   ##
==========================================
  Coverage           ?   34.75%           
  Complexity         ?       76           
==========================================
  Files              ?        1           
  Lines              ?      164           
  Branches           ?        0           
==========================================
  Hits               ?       57           
  Misses             ?      107           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1a595c...30d6b45. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@c1a595c). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #19   +/-   ##
==========================================
  Coverage           ?   34.75%           
  Complexity         ?       76           
==========================================
  Files              ?        1           
  Lines              ?      164           
  Branches           ?        0           
==========================================
  Hits               ?       57           
  Misses             ?      107           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1a595c...30d6b45. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@c1a595c). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #19   +/-   ##
==========================================
  Coverage           ?   34.75%           
  Complexity         ?       76           
==========================================
  Files              ?        1           
  Lines              ?      164           
  Branches           ?        0           
==========================================
  Hits               ?       57           
  Misses             ?      107           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1a595c...30d6b45. Read the comment docs.

abbadon1334 commented 5 years ago

Coverage is back, sorry. I see a losing of coverage, if you want to merge this PR, i will look further in the issue and i will open another one only to increase coverage, because i think api must have higher rate of testing. Moreover with all the microservice request of the community and with last addiction of atk4/data action probably will be used more.