Quick search filter for Grid

atk4 / atk4-addons

Agile Toolkit Addons

http://atk4.com/

Other

15 stars 23 forks source link

Quick search filter for Grid #34

Closed oleksiiostapets closed 10 years ago

oleksiiostapets commented 11 years ago

Quick search filter for Grid needed for project Lims

DarkSide666 commented 11 years ago

OK, I'll give it a try sometime soon, but I believe it would be better to move presentation layer out of controller to template + css. I mean, moving all these ->add(View)->setElement()->addClass() etc. to gridqsearch.html + gridqsearch.css. That way this add-on will be easier to extend.

I added some comments in source code too, but I need to admit that I have not tested this yet :)

romaninsh commented 11 years ago

My notes:

i thought it might pull characters of different case from that expr() and duplicate 'a/A'
will this work with localized characters?
separate repo and packagist.org repository would be best
prefix GET argument to avoid conflicts (e'g' if you have 2 paginators in seprate tabs reseting one would reset another too)
ideally you would want to have rendering during render phase. You can move your code pretty safely into recursiveRender() before you call parent (so that it can render View's you add)

DarkSide666 commented 11 years ago

One more thing to consider and implement is character case. First letter can be in uppercase and lowercase - what will happen then?

oleksiiostapets commented 11 years ago

about "uppercase and lowercase"

the filter will show only one letter. Filtering by the letter will show both variants in the grid. Example: grid has "Alex" and "anton" Filter will have "A", click show both