search

atk4 / autocomplete

Implementation of AutoComplete functionality
1 stars 4 forks source link

_load() changed to addStaticInclude() #8

Open KonstantinKolodnitsky opened 10 years ago

DarkSide666 commented 10 years ago

What's the point?

As far as I found out in ATK code (4.2.5) then _load is actually the same as addStaticInclude.

_load calls api->jquery->addInclude and addInclude calls addStaticInclude

KonstantinKolodnitsky commented 10 years ago

It's for ATK 4.3. Probably it should be made in another branch.

DarkSide666 commented 10 years ago

Ah I see. But this isn't breaking compatibility with 4.2.5, right? If so, then I can merge this in.

DarkSide666 commented 10 years ago

This will break, because _load can be replaced with addStaticInclude, but _css can't. Maybe _css can be replaced with addStaticStylesheet, but I'm not sure it'll be compatible with 4.3 AND 4.2 then. Can you please check that out? I have not used 4.3 yet and don't know much about it :(