atk4 / data

Data Access PHP Framework for SQL & high-latency databases
https://atk4-data.readthedocs.io
MIT License
273 stars 46 forks source link

Fix Model::loadXxx() /w limit/offset set #1011

Closed mvorisek closed 2 years ago

mvorisek commented 2 years ago

fixes https://github.com/atk4/data/issues/1010

Array persistence does not need fix, as it wraps the Action

most tests should run /w all persistences but a lot of test redesign is needed

mvorisek commented 2 years ago

@mkrecek234 thank you for the report, the limit offset was also broken, now it should be fixed for both Array/SQL persistences

mvorisek commented 2 years ago

before merge, I will also emulate support for MSSQL for limit = 0, all other DBs support it