atk4 / data

Data Access PHP Framework for SQL & high-latency databases
https://atk4-data.readthedocs.io
MIT License
273 stars 46 forks source link

Make SQL Expression & Query classes abstract #1048

Closed mvorisek closed 2 years ago

mvorisek commented 2 years ago

Specific driver class is needed to determine correct SQL template and identifier escape character.

Instead of:

new Expression(['connection' => $connection]);
new Query(['connection' => $connection]);

always use

$connection->expr()
$connection->dsql();

Also removing new DBAL 3.4+ support temporary, as many changes are needed like for https://github.com/doctrine/dbal/pull/5513/files#r945271960.