Expression::render must not mutate the state

atk4 / data

Data Access PHP Framework for SQL & high-latency databases

https://atk4-data.readthedocs.io

MIT License

273 stars 46 forks source link

Expression::render must not mutate the state #938

Closed mvorisek closed 2 years ago

mvorisek commented 2 years ago

fixes several hidden bugs and also https://github.com/atk4/data/pull/784

BC break

Expression::render() does no longer mutate the instance state, the result of the method is now an array with a rendered SQL and corresponding params

this method is expected to be not used in a higer level code thus the impact should be minimal