refactor to use Exception from atk4/core

atk4 / dsql

Object-Oriented SQL Query Builder

https://agiletoolkit.org/

MIT License

58 stars 23 forks source link

refactor to use Exception from atk4/core #88

Closed romaninsh closed 8 years ago

romaninsh commented 8 years ago

because, why keep exceptions in both locations.. ?

DarkSide666 commented 8 years ago

Then atk4/dsql will have dependency with atk4/core. Currently dsql have no dependecies.

romaninsh commented 8 years ago

ok, we can also probably move exception colouring code into some separate class... what do you propose?

DarkSide666 commented 8 years ago

yeah, atk4/exception :) actually - why not? I'm not against dsql dependency from core, but in this case I think we can do that without linking dsql and core repos together.

romaninsh commented 8 years ago

ok, let's leave as-is.