search

atk4 / filestore

Implements integration between ATK UI and FlySystem
https://agiletoolkit.org/
MIT License
9 stars 8 forks source link

atk4/ui 2.1 breaks code #16

Closed mkrecek234 closed 4 years ago

mkrecek234 commented 4 years ago

This does not work anymore: $this->addField('attachment', new \atk4\filestore\Field\File($this->app->filesystem));

Error: Error: Class 'atk4\filestore\Model\Model' not found

mkrecek234 commented 4 years ago

This issue is present with 2.1 after you applied the PR #17 to make onHook/addHook refactoring already.

mkrecek234 commented 4 years ago

This issue will be gone if you merge the in the meantime updated PR #17

domainoverflow commented 4 years ago

Hi @mkrecek234 , I am trying to make it work using the following version combination ( as the current one seems broken )

composer require atk4/core:2.0.2 atk4/data:2.0.3 atk4/dsql:2.0.2 atk4/filestore:0.1.0 atk4/ui:2.0.4 league/flysystem:1.0.69 psr/log:1.1.3

With that combination it goes as far as uploading the file, but upon upload it complains ( screenshot below ) so I was just wondering if you know how would I implement the onUpload and onDelete callback ? Thanks for any help !!

image

domainoverflow commented 4 years ago

I got onUpload to work. Trying to get onDelete now. I am using it in a CRUD.

mkrecek234 commented 4 years ago

Can you share this with us and push it to your fork? Or submit a PR? Thx!

Am 09.07.2020 um 11:58 schrieb DomainOverflow.com notifications@github.com:

I got onUpload to work. Trying to get onDelete now. I am using it in a CRUD.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/atk4/filestore/issues/16#issuecomment-656033099, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG2X37UV562OLF5BCL4P3G3R2WIDXANCNFSM4OO2672A.

domainoverflow commented 4 years ago

Yes sure I can share. I've never done a PR though ... I can push to my fork yes, would that do ? Everything is working now except the onDelete when triggered from the form control ( the red x ). From the CRUD class is a problem because that breaks the update. The upload works nicely from the CRUD.

mkrecek234 commented 4 years ago

Addressed by release 0.2.0