search

atk4 / report

Reporting extension for Agile Data
https://agiletoolkit.org/
MIT License
3 stars 6 forks source link

GroupModel->addCondition is not working #13

Closed romaninsh closed 7 years ago

romaninsh commented 7 years ago

If I group model and addCondition then it will be conditioned on the nested model. Thats' wrong, if a wanted that , i would do

$group->master_model->addCondition();

So the condition should be on the grouped expression.

DarkSide666 commented 7 years ago

Maybe it would be even better to implement this like it's done in UnionModel. If GroupModel has such field, then add condition on that field (expression), if GroupModel doesn't have such field, but $group_model->master_model does, then add condition on master_model.