search

atk4 / report

Reporting extension for Agile Data
https://agiletoolkit.org/
MIT License
3 stars 6 forks source link

Try to fix for atk4/data 1.4.1 #29

Closed abbadon1334 closed 4 years ago

abbadon1334 commented 5 years ago

I try to upgrade to 1.4.1, i arrive at a point where i get some "errors" that are related to expression quoting in atk4/dsql.

Can someone put an eye on this, i don't want to arbitrary change the test to make it pass?

Failed asserting that two strings are equal.
Expected :'select sum(`cnt`) from ((select count(*) `cnt` from `invoice`) UNION ALL (select count(*) `cnt` from `payment`)) `derivedTable`'
Actual   :'select sum(cnt) from ((select count(*) `cnt` from `invoice`) UNION ALL (select count(*) `cnt` from `payment`)) `derivedTable`'
<Click to see difference>

...atk4/report/tests/UnionExprTest.php:97
abbadon1334 commented 5 years ago

i add split phpunit sqlite + phpunit mysql and add travis file, @romaninsh can you activate CI to this repo?

romaninsh commented 5 years ago

@PhilippGrashoff Me or @DarkSide666 should look into this.

DarkSide666 commented 5 years ago

https://github.com/atk4/report/pull/31 should go in first and then see what good we can take from this PR in.

DarkSide666 commented 4 years ago

This issue and few others are fixed in https://github.com/atk4/report/pull/31. Currently tests run fine on MySQL. I didn't test on other persistences, because they will use different escaping symbol and then we will need to fix tests (replace hard-coded escaping symbol to one from persistence).

Also extracted part of this PR and commited in develop branch. So only thing left uncommited from this PR is part with Travis and Codeclimate tests. But we're moving to use Github Actions, so I guess these are not needed anymore.

abbadon1334 commented 4 years ago

i close this for now, if needed we can reopen it